Prefer require_relative for internal requires
#831
Conversation
`require_relative` is preferred over `require` for files within the same project because it uses paths relative to the current file, making code more portable and less dependent on the load path. This change updates internal requires to use `require_relative` for consistency, performance, and improved portability. Refs: - rubocop/rubocop#8748
|
Thank you for the PR. I read through the discussion in Rubocop. I didn't see any compelling arguments for why this would be better. I'm of the opinion that relying on the load path is a Good Thing, specifically because it allows flexibility. To be even more specific, if you for any reason wanted to prevent Pundit from loading e.g. Using I'm open to hearing solid arguments about this, but without that this is a hard pass. |
|
Thanks, can you share the concerns on the rubocop discussion? It may help others in deciding |
That's a good suggestion, thank you! |
|
rubocop/rubocop#8748 (comment) I wrote a comment. Thank you for the push! |
require_relativeis preferred overrequirefor files within the same project because it uses paths relative to the current file, making code more portable and less dependent on the load path.This change updates internal requires to use
require_relativefor consistency, performance, and improved portability.Refs:
require_relativerubocop/rubocop#8748To do
I have added relevant tests.I have adjusted relevant documentation.I have added relevant lines to the CHANGELOG.PS: Thank you for contributing to Pundit ❤️
I think this does not deserve an entry in the changelog
Relevant comment: rubocop/rubocop#8748 (comment)